Fixed position share menu on scroll #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unl#974 Share popup does not stick with the nav and icon
* Removed redundant z-index (declared on line 2 of layouts/share.less) * Removed redundant top and fixed positioning (already handled by .wdn-menu-trigger's flexbox align:center and fixed: position) * Didn't remove transition property (yet?) as difficult to test due to issue unl#973 * Positioning of share menu popup could still be improved for desktop Fixes issue unl#974 Share popup does not stick with the nav and icon
* Padding, color already declared in layouts/navigation.less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: I thought I had undid commit 1a61334, but it is included (and changed by a subsequent commit) here. I don't think its inclusion necessarily hurts anything.
I will continue to work on visual improvements related to this update before (and possibly after, too) deployment next week.